-
Notifications
You must be signed in to change notification settings - Fork 319
Issue #1228 - Feature: support extensions in utoipa::path macro #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #1228 - Feature: support extensions in utoipa::path macro #1292
Conversation
|
Convert to draft as I noticed the PR test suite is not passing - and also have a couple of tweaks I thought of. |
|
hi @juhaku, friendly ping - just checking in if there's any chance you'd be able to get to review this soon. no worries if not! |
|
@juhaku Heya! Would you mind merging this? |
|
I too!!! |
juhaku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, could you add new entry to utoipa-gen/CHANGELOG.md file under the Unreleased and Added title.
|
@infiniteregrets @redactedontop @IvanProg00 Hey thanks for patience, this looks good to me 🥇 Just missing CHANGELOG entry and it can be merged. |
…responses, responses>content, request_body
7cd1db9 to
b54da7a
Compare
Hi,
This is a first attempt at implementing extensions within the
utoipa::pathmacro. Read the PR in conjunction with the issue #1228 .The
extensionsis implemented for the following parts of theutoipa::pathmacro:The implementation uses the form (as discussed in the issue):
The parsing and building of the token stream is done in a struct
Extensions- which I located undercomponents/features/attributes. I decided to split it into its own file that is loaded inattributes.rsasattributes.rsis already quite long. But not sure (a) if it makes sense as a child ofattributesand (b) if ok to split into its own separate file.Also, I used
use super::*;at the top of theextensions.rs. Happy to modify to just what is needed if this is the recommended approach.What is included:
Closes #1228 Closes #1255