Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for jiff v0.2 #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juhaku merged 2 commits into from
Apr 23, 2025
Merged

Add support for jiff v0.2 #1332

juhaku merged 2 commits into from
Apr 23, 2025

Conversation

@Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Mar 7, 2025

This commit adds support for v0.2 of the jiff date-time crate, similar to how it is already implemented for chrono and time.

@Turbo87
Copy link
Contributor Author

Turbo87 commented Mar 11, 2025

@juhaku I guess the CI failure is unrelated to this PR, right? 🤔

@juhaku
Copy link
Owner

juhaku commented Mar 24, 2025

@juhaku I guess the CI failure is unrelated to this PR, right? 🤔

Yup, seems like it has been there long time, but for some reason typos has recently started to think it as a typo.

@Turbo87
Add support for jiff v0.2
11d3dfd 
This commit adds support for v0.2 of the `jiff` date-time crate, similar to how it is already implemented for `chrono` and `time`.
@Turbo87
Copy link
Contributor Author

Turbo87 commented Apr 7, 2025 •
edited
Loading

I've rebased and it looks like the CI run is green now :)

@tisonkun
Copy link

tisonkun commented Apr 18, 2025

@juhaku This patch would help a lot for downstream projects adopting utopia. Would you take another look?

juhaku
juhaku approved these changes Apr 18, 2025
View reviewed changes
Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, would you like update CHANGELOG as well in utoipa and utoipa-gen and it is ready to merge. @Turbo87

@juhaku
Copy link
Owner

juhaku commented Apr 18, 2025

Sorry for the delay here, there has been too much going on recently and I am struggling to find time maintain this project 😞

@tisonkun
Copy link

tisonkun commented Apr 18, 2025

@juhaku My use case relies on ToSchema and I wonder if these external supports can bringing to ToSchema/PartialSchema also. I have some time to investigate into this.

@juhaku
Copy link
Owner

juhaku commented Apr 18, 2025

ToSchema and PartialSchema can be implemented only for owned types. For third-party types it is not possible and this current schema_type.rs mapping is exactly to mitigate this issue. Although utoipa could implemented PartialSchema for external type manually. Something like this has been done in utoipa before for some container types where they implement ComposeSchema.

@juhaku juhaku merged commit ac71b23 into juhaku:master Apr 23, 2025
12 checks passed
@Turbo87
Copy link
Contributor Author

Turbo87 commented Apr 24, 2025

Looks great, would you like update CHANGELOG as well in utoipa and utoipa-gen and it is ready to merge. @Turbo87

oops, sorry, I missed that notification 🙈

@juhaku
Copy link
Owner

juhaku commented Apr 24, 2025

Looks great, would you like update CHANGELOG as well in utoipa and utoipa-gen and it is ready to merge. @Turbo87

oops, sorry, I missed that notification 🙈

No worries, I updated them, 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juhaku juhaku juhaku approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Turbo87 @juhaku @tisonkun