Thanks to visit codestin.com
Credit goes to github.com

Skip to content

swagger-ui: Use zip 3.0.0#1391

Merged
juhaku merged 2 commits intojuhaku:masterfrom
jayvdb:bump-zip
May 18, 2025
Merged

swagger-ui: Use zip 3.0.0#1391
juhaku merged 2 commits intojuhaku:masterfrom
jayvdb:bump-zip

Conversation

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented May 15, 2025

Fixes #1390

@jayvdb
Copy link
Contributor Author

jayvdb commented May 15, 2025

Hmm, CI doesnt appear to be running properly; from the log:

utoipa-swagger-ui changes: false

@Teebor-Choka
Copy link

Teebor-Choka commented May 15, 2025

Maybe you also need to bump the crate version as well, and make sure that the utoipa-swagger-ui-vendored is updated too.

Also, from

elif [[ "$change" == "utoipa-swagger-ui" && "${{ matrix.crate }}" == "utoipa-swagger-ui" && $changes == false ]]; then
changes=true
elif [[ "$change" == "utoipa" && "${{ matrix.crate }}" == "utoipa" && $changes == false ]]; then
changes=true
elif [[ "$change" == "utoipa-redoc" && "${{ matrix.crate }}" == "utoipa-redoc" && $changes == false ]]; then
changes=true
elif [[ "$change" == "utoipa-rapidoc" && "${{ matrix.crate }}" == "utoipa-rapidoc" && $changes == false ]]; then
changes=true
elif [[ "$change" == "utoipa-scalar" && "${{ matrix.crate }}" == "utoipa-scalar" && $changes == false ]]; then
changes=true
elif [[ "$change" == "utoipa-axum" && "${{ matrix.crate }}" == "utoipa-axum" && $changes == false ]]; then
changes=true
elif [[ "$change" == "utoipa-config" && "${{ matrix.crate }}" == "utoipa-config" && $changes == false ]]; then
changes=true
elif [[ "$change" == "utoipa-actix-web" && "${{ matrix.crate }}" == "utoipa-actix-web" && $changes == false ]]; then
changes=true
fi
done < <(git diff --name-only ${{ github.sha }}~ ${{ github.sha }} | grep .rs | awk -F \/ '{print $1}')

It'd seem the grep only looks for changes in *.rs files, so the .toml file change is insufficient.

@levish0
Copy link

levish0 commented May 16, 2025

@juhaku

Copy link

@Teebor-Choka Teebor-Choka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok.

Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great looks good

@juhaku juhaku merged commit cecda05 into juhaku:master May 18, 2025
12 checks passed
@jayvdb jayvdb deleted the bump-zip branch May 18, 2025 23:47
@bachp
Copy link

bachp commented May 23, 2025

@juhaku Would it be possible to do a patch release with the updated zlib dependency. The dependency on a yanked version prevents updates via cargo update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[utoipa-swagger-ui] build dependency zip version 2.6 is yanked

5 participants