-
Notifications
You must be signed in to change notification settings - Fork 15
Adding DIM and RAS command #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Onkyo.js need to be updated according to new group, right ? |
|
here is example for function that needs parameter: Line 653 in 637e908
rest of commands you added should work - new api’s are generated automatically -> did you try these APi’s already? |
|
OK got it No i'have not already tested in my module. I will test dimmer tonight and push setDimmerLevel to the PR |
|
After some test: onkyo.dimmerLevelBright();
onkyo.dimmerLevelDimmerStatus()
.then((value) => {
console.log(value);
});I have always theses error and i dont understand Get timeout for dimmer function and cinema filter, so not a success.
I have no info to set dimmer level ( DIM01 ) similar to volume ? hex parameter ? |
|
you need to add RAS and DIM parsers here: Line 148 in 637e908
there is plenty of examples so probably some of existing are similar what you need here.. |
|
Looking good to me |
lib/onkyo.commands.js
Outdated
| { | ||
| OFF: 'RAS00', | ||
| ON: 'RAS01', | ||
| FILTER_UP: 'RASUP', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generated API for this will be onkyo.cinemaFilterFilterUp(), is it intention? maybe just key UP?
lib/onkyo.commands.js
Outdated
| OFF: 'RAS00', | ||
| ON: 'RAS01', | ||
| FILTER_UP: 'RASUP', | ||
| FILTER_STATUS: 'RASQSTN' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be just STATUS?
|
Of course shorter is better |
|
Seems that I haven’t configure ext PR’s to be run in circle. now I did but seems that build is not triggered until some changes happen. Anyway, this should be good to merge so i will merge in. |
Status
READY
Migrations
NO
Description
Add missing commands
Related PR/Issues
Fixes part of #28 , DIM01 need parameter to set dim level