Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@VonOx
Copy link
Contributor

@VonOx VonOx commented Aug 27, 2018

Status

READY

Migrations

NO

Description

Add missing commands

Related PR/Issues

Fixes part of #28 , DIM01 need parameter to set dim level

@VonOx VonOx requested a review from jupe as a code owner August 27, 2018 08:54
@VonOx
Copy link
Contributor Author

VonOx commented Aug 27, 2018

Onkyo.js need to be updated according to new group, right ?

@jupe
Copy link
Owner

jupe commented Aug 27, 2018

here is example for function that needs parameter:

setVolume(volume) {

rest of commands you added should work - new api’s are generated automatically ->

sourceSelectTv()
dimmerLevelBright()
dimmerLevelDark()
..

did you try these APi’s already?

@VonOx
Copy link
Contributor Author

VonOx commented Aug 27, 2018

OK got it

No i'have not already tested in my module.
https://github.com/VonOx/gladys-onkyo

I will test dimmer tonight and push setDimmerLevel to the PR

@VonOx
Copy link
Contributor Author

VonOx commented Aug 29, 2018

After some test:

onkyo.dimmerLevelBright();
    onkyo.dimmerLevelDimmerStatus()
      .then((value) => {
        console.log(value);
    });

I have always theses error and i dont understand

RX: unknown event: Error: Unknown data: RAS00
RX: unknown event: Error: Unknown data: DIM00
RX: unknown event: Error: Onkyo does not support this command

Get timeout for dimmer function and cinema filter, so not a success.

sourceSelectTv() is ok \o/


I have no info to set dimmer level ( DIM01 ) similar to volume ? hex parameter ?

@jupe
Copy link
Owner

jupe commented Aug 30, 2018

you need to add RAS and DIM parsers here:

switch (group) {

there is plenty of examples so probably some of existing are similar what you need here..
Actually I should add short documentation about these..

@VonOx VonOx changed the title Adding missing command to Adding DIM and RAS command Aug 30, 2018
@VonOx
Copy link
Contributor Author

VonOx commented Aug 30, 2018

Looking good to me

{
OFF: 'RAS00',
ON: 'RAS01',
FILTER_UP: 'RASUP',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated API for this will be onkyo.cinemaFilterFilterUp(), is it intention? maybe just key UP?

OFF: 'RAS00',
ON: 'RAS01',
FILTER_UP: 'RASUP',
FILTER_STATUS: 'RASQSTN'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be just STATUS?

@VonOx
Copy link
Contributor Author

VonOx commented Aug 30, 2018

Of course shorter is better

@jupe
Copy link
Owner

jupe commented Aug 31, 2018

Seems that I haven’t configure ext PR’s to be run in circle. now I did but seems that build is not triggered until some changes happen. Anyway, this should be good to merge so i will merge in.

@jupe jupe merged commit 8567148 into jupe:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants