Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Python 3, PEP-8, docs, and more #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Python 3, PEP-8, docs, and more #1

wants to merge 3 commits into from

Conversation

@codekoala
Copy link

I've done a fair mount of refactoring to the script here. Some of the highlights:

  • less dependent upon a specific filesystem layout
  • should work with both Python 2 and 3 now
  • reduced redundancy in a few places
  • added a check to see if haproxy is installed before running
  • restarting haproxy directly with the subprocess.call function, rather than using it to call a shell script
  • some PEP-8 items
  • lots of docstrings... I hope they're accurate enough for you

codekoala added 3 commits July 19, 2014 22:24
@codekoala
PEP-8, Python 3, and documentation
06576d8
@codekoala
Fairly large refactor...
0f8ef80 
- more flexible shebang
- restart haproxy directly rather than using shell script
- check that haproxy is installed and on the PATH before running
- more docs
- connect to etcd once
- created main() function
- simplified main procedure
@codekoala
Removed script to reload haproxy
6ba0360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@codekoala