Add additional device support and capability query#9
Merged
jxltom merged 3 commits intojxltom:masterfrom Aug 29, 2022
Merged
Conversation
Owner
|
This is nice, thanks for the effort! |
Contributor
Author
|
Thanks @jxltom Is there anything that needs to be done to push these changes to pypi as a release or will that happen automatically? I've not done it before so am unsure. |
Owner
|
@BennyEvans usually I will release it manually and now v0.3.0 is released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for additional devices by VID/PID as listed in the current linux kernel driver.
Device capabilities are now queried and only device and driver supported features can be set. This also queries for the device clock so that CAN bit timing settings are set correctly based on the specific device clock. My plan is to create another PR in the future that automatically calulates the best bit timing for a device given it's capability. I currently have a script to do this, but it needs some cleaning up.
Just for transparency, I am the developer of the ABE CAN Debugger, but this device is still being actively developed.
Let me know if you have any thoughts or suggestions. I'm happy to work with you on this. Additional testing would also be great.
Cheers,
Ben