Refine the heuristic used to recognize commit SHAs #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacebrowning
reviewed
May 4, 2018
gitman/git.py
Outdated
| commit SHA. The minimum of 7 digits is not an arbitrary choice, it | ||
| is the default length for short SHAs in Git. | ||
| """ | ||
| re.match('^[0-9a-f]{7,40}$', rev) is not None |
There was a problem hiding this comment.
You need a return statement here. 😉
There was a problem hiding this comment.
Thanks for pointing it out. Too bad that Pylint did not warn me about that one. I mostly code in programming languages where no return statement is needed... so it's easy for me to forget!
There was a problem hiding this comment.
pylint should catch that, but there was some sort of issue installing dependencies on Travis CI. Please rebase on develop.
There was a problem hiding this comment.
OK, it is probably because my Pylint is for Python 2 and this project uses Python 3. I have rebased, let's see now.
374416e to
daf0b39
Compare
The previous test `len(rev) == 40` does not allow for short SHAs, and would incorrectly identify a 40-char branch or tag name as a SHA. A better trade-off is to require `rev` to be a sequence of hexadecimal digits in order to be recognized as a SHA, while allowing SHAs shorter than 40 digits.
jacebrowning
approved these changes
May 4, 2018
|
Thanks for the PR! Closes #166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous test
len(rev) == 40does not allow for short SHAs, andwould incorrectly identify a 40-char branch or tag name as a SHA.
A better trade-off is to require
revto be a sequence of hexadecimaldigits in order to be recognized as a SHA, while allowing SHAs shorter
than 40 digits.