Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@cgtobi
Copy link
Collaborator

@cgtobi cgtobi commented Dec 15, 2023

This is a breaking change as it removed previously deprecated modules and functions

jabesq and others added 9 commits November 7, 2023 12:49
* Remove deprecated code

* Remove old codeql config

* Remove unused fixture

* Minor clean up

* Refactor async_post_request

Signed-off-by: Tobias Sauerwein <[email protected]>

---------

Signed-off-by: Tobias Sauerwein <[email protected]>
* split tests

* clean up cruft

* Fix NLPD to provide energy readings

* Add BNLD - Bticino dimmable light
* Clean up somfy shutter
* Add new bticino scope
* update readme
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.1 to 5.0.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4.7.1...v5.0.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@cgtobi cgtobi requested a review from jabesq as a code owner December 15, 2023 09:41
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request focuses on removing deprecated modules and functions as part of a major version release. It includes refactoring of authentication handling, streamlining of response processing, and cleanup of test fixtures.

General suggestions:

  • Ensure that the removal of deprecated modules and functions is well-documented in the release notes to inform users about the breaking changes.
  • Verify that the refactoring of the authentication classes does not introduce any regressions or changes in behavior that could affect existing integrations.
  • Review the updated response processing logic to ensure that it correctly handles all expected cases, including error handling and content type verification.
  • Confirm that the removal of test fixtures and related code does not impact the ability to thoroughly test the remaining functionality.

Your trial expires on December 16, 2023. Please email [email protected] to continue using Sourcery ✨

@cgtobi cgtobi merged commit 0d3bf6b into master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants