Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: NLIS module, remove the device_categroy type of the base module entity #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cgtobi merged 3 commits into from
May 12, 2025
Merged

fix: NLIS module, remove the device_categroy type of the base module entity #529

cgtobi merged 3 commits into from
May 12, 2025

Conversation

@fabienduval
Copy link
Contributor

@fabienduval fabienduval commented May 11, 2025 •
edited by sourcery-ai bot
Loading

The NLIS module is represented with 3 modules in the API:

  • The module itself (id: "xx:yy:zz")
  • The two contactors (ids: "xx:y:zz#A"

Only the contactors can be controlled.

Summary by Sourcery

Update NLIS module handling to prevent assigning a device_category to the base module entity, reflecting that only contactors are controllable, and add corresponding tests.

Bug Fixes:

  • Ensure only NLIS contactor modules are assigned a device_category, not the base module entity.

Tests:

  • Add test to verify device_category assignment for NLIS modules and their contactors.

@fabienduval fabienduval requested review from cgtobi and jabesq as code owners May 11, 2025 20:34
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 11, 2025 •
edited
Loading

Reviewer's Guide

This pull request updates the NLIS module implementation so that only the contactor entities are assigned a device_category, while the base module entity has device_category set to None, and adds corresponding test coverage.

File-Level Changes

Change Details Files
Removed device_category assignment for base NLIS module entity and updated tests accordingly.
  • Modified NLIS class constructor to set device_category to None for base module entity (without '#')
  • Added test to verify device_category is None for base NLIS module and DeviceCategory.switch for contactor entities
 src/pyatmo/modules/legrand.py
tests/test_switch.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed May 11, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fabienduval - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

cgtobi
cgtobi approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @fabienduval

@cgtobi cgtobi merged commit d0417b8 into jabesq-org:development May 12, 2025
5 checks passed
jabesq
jabesq approved these changes May 12, 2025
View reviewed changes
tests/test_switch.py
assert module.power == 0


@pytest.mark.asyncio()
Copy link
Member

@jabesq jabesq May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For next time, No need for this mark, pytest-asyncio is set in auto mode (I'm currently in a work to remove all of this asyncio marks)

Copy link
Collaborator

@cgtobi cgtobi May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up @jabesq

wuede pushed a commit to wuede/pyatmo that referenced this pull request May 16, 2025
@fabienduval
fix: NLIS module, remove the device_categroy type of the base module …
012ae7a 
…entity (jabesq-org#529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgtobi cgtobi cgtobi approved these changes

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@jabesq jabesq jabesq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabienduval @cgtobi @jabesq