Only retain state and configuration, not events. #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks good to me, thank you again for the contribution! |
Owner
|
Would you classify this as a feature or a fix? I'm trying to figure out what the best commit type to use for the semantic release. |
Contributor
Author
|
Hmm… probably a fix. |
jakowenko
added a commit
that referenced
this pull request
Oct 27, 2022
## [1.13.1-beta.1](v1.13.0...v1.13.1-beta.1) (2022-10-27) ### Bug Fixes * **mqtt:** only retain state and configuration, not events. ([#249](#249)) ([d5de0ee](d5de0ee))
Owner
|
🎉 This PR is included in version 1.13.1-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jakowenko
added a commit
that referenced
this pull request
Oct 27, 2022
## [1.13.1](v1.13.0...v1.13.1) (2022-10-27) ### Bug Fixes * **mqtt:** only retain state and configuration, not events. ([#249](#249)) ([d5de0ee](d5de0ee))
Owner
|
🎉 This PR is included in version 1.13.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you retain events (like someone appearing at a camera), it makes it hard to design automations that won't trigger on every MQTT reconnection. This PR keeps all the state and Home Assistant configuration as "retain", but moves the /matches/{topic} and /cameras/{camera} to no longer "retain".