remove App{Archive,ArchiveConfig,Deployment}, rename AppArchiveBuilder and ContextBuilder #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just a first round of improvements I have in mind. More will follow for sure. Since @graemerocher started improving the language model part, I started looking at the actual extension API, so that we don't clash (hopefully :-) ). |
Ladicek
commented
Jul 27, 2021
| /** | ||
| * Registers custom context as configured by the returned {@link ContextConfig}. | ||
| */ | ||
| ContextConfig addContext(); |
There was a problem hiding this comment.
At this point, maybe we should just have addContext(Class<? extends AlterableContext>) (which is the only mandatory part) and leave ContextConfig purely for the optional stuff?
api/src/main/java/jakarta/enterprise/inject/build/compatible/spi/ScannedClasses.java
Outdated
Show resolved
Hide resolved
88f492d to
7197328
Compare
…r and ContextBuilder The `AppArchive`, `AppArchiveConfig` and `AppDeployment` types were redundant. Moreover, they looked like they can access whole world, which prevents certain kinds of implementations. (Some effort was made to design the API in these types so that whole world access is not necessary, but it's a leaky abstraction.) For those reasons, these types are removed altogether. The `AppArchiveBuilder` type is renamed to `ScannedClasses`, which is more descriptive (and shorter). The `addSubtypesOf` method is removed, because it can't be implemented in certain environments (notably, Portable Extensions). The `ContextBuilder` type is renamed to `ContextConfig`, because it isn't really used in the usual builder way and is quite close to the other existing `*Config` types. Additionally, some documentation is improved, especially for types in the `@Discovery` phase.
7197328 to
deb6d74
Compare
graemerocher
approved these changes
Jul 29, 2021
|
Great this makes life much simpler. You working the AnnotationBuilder PR now? |
|
I do, yes. Should be up shortly -- I have to resist the urge to change too many things at once :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AppArchive,AppArchiveConfigandAppDeploymenttypeswere redundant. Moreover, they looked like they can access whole
world, which prevents certain kinds of implementations. (Some
effort was made to design the API in these types so that whole
world access is not necessary, but it's a leaky abstraction.)
For those reasons, these types are removed altogether.
The
AppArchiveBuildertype is renamed toScannedClasses,which is more descriptive (and shorter). The
addSubtypesOfmethod is removed, because it can't be implemented in certain
environments (notably, Portable Extensions).
The
ContextBuildertype is renamed toContextConfig, becauseit isn't really used in the usual builder way and is quite close
to the other existing
*Configtypes.Additionally, some documentation is improved, especially for
types in the
@Discoveryphase.