Language model and build compatible extensions API clarifications #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- renamed `BeanInfo.getName()` to `name()` for consistency - renamed `ObserverInfo.observedType()` to `eventType()` for clarity - added `SyntheticComponents.addObserver(Type)` to allow registering synthetic observers of parameterized types - changed `WildcardType` representation to always include an upper bound; the `? extends Object` type is no longer represented as `?` because the upper bound may be annotated - improved specification of `AnnotationTarget`, especially around repeatable annotation types - improved specification of `ClassInfo` and `MethodInfo`, especially around implicit declarations and `abstract` classes/methods
|
These changes are motivated by my TCK work. It should be the last batch of changes, at least to the language model, whose TCK should now be complete (jakartaee/cdi-tck#310). I'll continue working on the build compatible extensions tests, which may motivate some changes in the extension API, but hopefully minimal. |
graemerocher
approved these changes
Nov 22, 2021
|
Actually I just realized that the commit message is wrong, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BeanInfo.getName()toname()for consistencyObserverInfo.observedType()toeventType()for claritySyntheticComponents.addObserver(Type)to allow registeringsynthetic observers of parameterized types
WildcardTyperepresentation to always include an upperbound; the
? extends Objecttype is no longer represented as?because the upper bound may be annotated
AnnotationTarget, especially aroundrepeatable annotation types
ClassInfoandMethodInfo, especiallyaround implicit declarations and
abstractclasses/methods