Small corrections to project information files #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update the repository URLs in CONTRIBUTING * List all the repositories in NOTICES * Remove reference to Signed-off-by in CONTRIBUTING as it's no longer required
e17aef7 to
d6bf6cc
Compare
Ladicek
reviewed
Feb 19, 2024
CONTRIBUTING.adoc
Outdated
|
|
||
| injection-spec - Project repository hosted on GitHub. | ||
| `clone: https://github.com/eclipse-ee4j/injection-spec.git` | ||
| `clone: https://github.com/jakartaee/injection-spec.git` |
There was a problem hiding this comment.
It is in fact https://github.com/jakartaee/inject-spec
Ladicek
reviewed
Feb 19, 2024
CONTRIBUTING.adoc
Outdated
|
|
||
| injection-api - Project repository hosted on GitHub. | ||
| `clone: https://github.com/eclipse-ee4j/injection-api.git` | ||
| `clone: https://github.com/jakartaee/injection-api.git` |
There was a problem hiding this comment.
It is in fact https://github.com/jakartaee/inject
Ladicek
reviewed
Feb 19, 2024
CONTRIBUTING.adoc
Outdated
|
|
||
| cdi-tck - Project repository hosted on GitHub. | ||
| `clone: https://github.com/eclipse-ee4j/cdi-tck.git` | ||
| `clone: https://github.com/jakartaee/injection-tck.git` |
There was a problem hiding this comment.
https://github.com/jakartaee/inject-tck
Ladicek
reviewed
Feb 19, 2024
NOTICE.md
Outdated
| * https://github.com/jakartaee/cdi-tck | ||
| * https://github.com/jakartaee/injection-api | ||
| * https://github.com/jakartaee/injection-spec | ||
| * https://github.com/jakartaee/injection-tck |
There was a problem hiding this comment.
See above for correct URLs.
|
I see similar changes were also done in jakartaee/cdi-tck#541, we'll need to fix the URLs there as well. |
207aea0 to
d0a80f8
Compare
|
@Ladicek Thank you, well spotted. I've fixed these URLs and have gone through and checked the rest of the links (as I should have done before). I've opened jakartaee/cdi-tck#543 to make the same change in the TCK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-byin CONTRIBUTING as it's no longer requiredI noted a few things in these files that should be updated before I copy them over to the TCK repo.