change Iterable<E> to List<E> in lifecycle method signatures #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is way more friendly to both users and implementors
njr-11
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
List will be much more convenient for users than Iterable for accessing and using the results. In addition to the changes you made, there is also an occurrence of Iterable that needs updating to List in module-info.
* <li>the class of the entity, or</li>
* <li>{@code Iterable<E>} or {@code E[]} where {@code E} is the class of the
* entities.</li>
* </ul>
Thanks, fixed! |
|
@otaviojava any objections to this? |
Nope, merged. |
otaviojava
reviewed
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is way more friendly to both users and implementors.
Iterableis an absolute PITA to work with, both for users, when a method returnsIterable, and for implementors, when a method accepts it. And there are no interesting types which implementIterablebut notCollection.Now, I considered making the substitution
Iterable->Collection, but really all that allows isSets. And here, in lifecycle methods,Setactually has the wrong semantics, because the returned values are correlated with input values by their order.So
Listis really the right thing to use here!