implement toString to make Restrictions more readable #962
Conversation
…able Signed-off-by: Nathan Rauh <[email protected]>
Signed-off-by: Nathan Rauh <[email protected]>
| */ | ||
| @Override | ||
| public String toString() { | ||
| StringBuilder s = new StringBuilder(); |
There was a problem hiding this comment.
If possible, avoid variables like s, please, use something like:
textExpression
or any variation like this.
There was a problem hiding this comment.
I renamed it in the latest commit.
api/src/main/java/jakarta/data/metamodel/restrict/CompositeRestrictionRecord.java
Outdated
Show resolved
Hide resolved
Why not align the (price >= 50 AND price < 100) |
|
Oh, wait, it was already merged? A bit quick, no? I think we should always leave time for reviews/feedback. |
That's a nice improvement, and I like how it is more concise.
I suppose he didn't realize I only created the PR yesterday? I guess we'll use a separate PR for the improvement. |
|
OK, perfect. |
Adds implementation of toString on the built-in Restrictions to display in a concise way that is meaningful.
For example,
name LIKE "Jakarta EE %"Or,
ALL (price GREATER_THAN_EQUAL 50, price LESS_THAN 100)