Add PHPStan to the project and CI #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Aug 1, 2023
Collaborator
WyriHaximus
left a comment
There was a problem hiding this comment.
Sounds like a great plan, want to do some major redecorating for 0.6 and this fits right in 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋
I wanted to add a more precise definition of the callbacks passed to the
Channel::consume()andChannel::run()method, when I saw that PHPStan was not in the project and I could not find any other kind of static code analysis. I would like to clean some things up (mostly adding missing types, and especially add the callback signature), so to begin with I thought it might be a good idea to bring PHPStan in the CI.I would like to keep this PR small, so I would start adding cleanups in a separate PR, if this is okay with you.
WDYT?