Global handling of channel and connection close #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the closure of the channel or connection is properly handled only when the
awaitListin theConnectionobject is empty. In that case, the relevant frames are processed by theonFrameReceivedfunction of either the channel or the connection. However, if such a frame reaches a frame handler on theawaitList, the global closure handling is ignored. As a result, the objects do not transition to their proper states, the closed channel is not removed from the client's channel list, and other necessary cleanup actions are not performed.I propose that for two specific frame types:
MethodConnectionCloseFrameandMethodChannelCloseFrame- we should invoke the appropriateonFrameReceivedfunctions, even if the frame handler from theawaitListhas already handled them.