forked from robbert-vdh/nih-plug
-
Notifications
You must be signed in to change notification settings - Fork 0
Introduce egui window resizability #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamesWalker55
wants to merge
37
commits into
jamesWalker55:james
Choose a base branch
from
tk70:master
base: james
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfc923d to
5190341
Compare
They get deprecated real fast, and since you can target a specific SDK version the runner used shouldn't matter that much. Hopefully.
This avoids a future incompatibility issue. robbert-vdh#202 rust-lang/rust#127323
20.04 is no longer supported by GitHub Actions.
Nothing sparks more joy than things that worked previously suddenly refusing to work because it's more than a year old.
`16c6c58f4d9f08c9c515c991c218bff235cff6e2` changed this to no longer refer to a specific runner (which should be fine with the target SDK option), but there was a typo in there.
Love these deprecations.
20.04 is probably going to be removed soon.
Because the V3 versions no longer work.
Apparently the `macos-latest` runner silently changed architectures with the macOS 14 update. Fun.
This was triggering a new deny-by-default lint in recent nightly versions.
Resolved warning: use of deprecated function std::arch::x86_64::_MM_GET_FLUSH_ZERO_MODE Issue robbert-vdh#220 Issue Link: robbert-vdh#220
Before:
Compiling nih_plug v0.0.0
warning: hiding a lifetime that's elided elsewhere is confusing
--> src\params\smoothing.rs:248:17
|
248 | pub fn iter(&self) -> SmootherIter<T> {
| ^^^^^ --------------- the same lifetime is hidden here
| |
| the lifetime is elided here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
= note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: use `'_` for type paths
|
248 | pub fn iter(&self) -> SmootherIter<'_, T> {
| +++
warning: `nih_plug` (lib) generated 1 warning
Finished `release` profile [optimized] target(s) in 2.27s
After:
Compiling nih_plug v0.0.0
Finished `release` profile [optimized] target(s) in 2.27s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.