Add score_cast_func support #172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
757d989 to
a8daf9a
Compare
a8daf9a to
98d1369
Compare
bmerry
requested changes
Mar 23, 2018
Collaborator
bmerry
left a comment
There was a problem hiding this comment.
This looks like a good start, thanks. It also needs to be added to zrange and zrevrange.
| self.redis.zadd('foo', three=3) | ||
| self.assertEqual(self.redis.zrangebyscore('foo', 1, 3, 0, 2, True, | ||
| int), | ||
| [(b'one', 1), (b'two', 2)]) |
Collaborator
There was a problem hiding this comment.
This is not an effective test, because it passes even if the score_cast_func isn't being applied. Rather use str as the cast func.
| int), | ||
| [(b'one', 1), (b'two', 2)]) | ||
|
|
||
| def test_zrevrangebyscore(self): |
Collaborator
There was a problem hiding this comment.
Add a test for zrevrangebyscore with score_cast_func as well.
Collaborator
|
Closing in favour of #194. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to pass a function to cast the score return value.