remove type check for primitive array values #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f2c6c4 to
3eb6cbe
Compare
Korbeil
requested changes
Aug 31, 2025
There was a problem hiding this comment.
I don't think validators will work here. We inject validators when required inside serialization / deserialization so it's totaly transparent when using Jane. Since there is no "object" in your case, you cannot use theses validators.
Could you fix CS & add a quick note about your changes in the CHANGELOG file please ? 🙏
3eb6cbe to
6eeee84
Compare
|
ah right cool my hunch was wrong :) will fix up the CI + changelog |
Korbeil
approved these changes
Sep 1, 2025
I did fixed some comments issue on |
Currently, when a request body is specified as an array of primitive values, the AbstractBodyContentGenerator will add an array type check for the first item of an array. This results in a client that never sends a request body when you pass an array of primitive values. This fix changes it to a simpler `is_array` check.
6eeee84 to
950b149
Compare
|
Thanks for fixing all this ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a request body is specified as an array of primitive values, the AbstractBodyContentGenerator will add an array type check for the first item of an array. This results in a client that never sends a request body when you pass an array of primitive values. This fix changes it to a simpler
is_array. It also removes theissetcheck for the first item as an empty array is valid if no min items are setfixes #828
feels like there's a opportunity to use the validators in here but I couldn't quite see how and thought a simpler change would be easier.