fix: command + N does not work #6890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR wraps a router navigation call in requestAnimationFrame to defer execution until the next browser paint cycle. This change affects the keyboard shortcut handler that navigates to the home route when triggered.
Key Changes:
- Modified the new chat keyboard shortcut callback to defer navigation using
requestAnimationFrame
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
5b95366 to
ac80c01
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
urmauur
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request introduces a minor update to the
KeyboardShortcutsProvidercomponent. The change ensures that navigation to the home route triggered by a keyboard shortcut is now wrapped in arequestAnimationFramecallback, which can help avoid potential UI update issues.router.navigatecall inrequestAnimationFramewithin the keyboard shortcut callback inKeyboardShortcutsProvider(KeyboardShortcuts.tsx).Fixes Issues
Self Checklist