(test): ensure custom --tsconfig path is correctly read#556
Merged
agilgur5 merged 1 commit intojaredpalmer:masterfrom Mar 11, 2020
Merged
(test): ensure custom --tsconfig path is correctly read#556agilgur5 merged 1 commit intojaredpalmer:masterfrom
agilgur5 merged 1 commit intojaredpalmer:masterfrom
Conversation
- this never had tests for it, so ensure it's properly read
- make sure extends works, that an override works, and that paths
are correctly resolved
9a5a4fb to
aa7f103
Compare
agilgur5
commented
Mar 11, 2020
Collaborator
Author
agilgur5
left a comment
There was a problem hiding this comment.
LGTM, pretty small PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
are correctly resolved
Basically ensure that #436 works