Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jaredpalmer
Copy link
Owner

No description provided.

@jaredpalmer jaredpalmer merged commit b09e195 into master Jul 17, 2020
@jaredpalmer jaredpalmer deleted the docs-extra branch July 17, 2020 15:25
@agilgur5
Copy link
Collaborator

agilgur5 commented Jul 18, 2020

It would be good to state the purpose of a new docs site given that the old one was never linked to and never updated and users didn't really mind either.

I'm also not sure why this was merged immediately with no code review and without CI even passing... EDIT: this then caused bugs I had to fix per #794... It had other issues like #844 (comment) / #848 too...
Pushing directly to master after on top of that is not good practice either and something I've never done...
You also did that just a few days after telling me "I hear you that dropping in [...] isn’t helpful to you and feels disruptive"...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants