-
Couldn't load subscription status.
- Fork 0
Bump FAnsiSql.Legacy from 3.3.1 to 3.3.4 #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
2
commits into
main
Choose a base branch
from
dependabot/nuget/main/FAnsiSql.Legacy-3.3.4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- updated-dependencies: - dependency-name: FAnsiSql.Legacy dependency-version: 3.3.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
- [x] Review the current Startup.cs file and understand the PreStartup method - [x] Add #pragma warning disable CS0618 before the ImplementationManager.Load calls - [x] Add a comment explaining why the pragma is required - [x] Add #pragma warning restore CS0618 after the calls - [x] Build the project to ensure the change compiles correctly - [x] Verify the change matches the desired replacement in the problem statement <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > Replace the PreStartup() implementation in Rdmp.Core/Startup/Startup.cs to silence the obsolete-warning CS0618 around ImplementationManager.Load<T>() calls while keeping the calls intact. > > File to modify: Rdmp.Core/Startup/Startup.cs (ref: bbe80bc, BlobSha: edfec72) > > Current content around PreStartup (lines ~279-285): > > public static void PreStartup() > { > ImplementationManager.Load<MicrosoftSQLImplementation>(); > ImplementationManager.Load<MySqlImplementation>(); > ImplementationManager.Load<OracleImplementation>(); > ImplementationManager.Load<PostgreSqlImplementation>(); > } > > Change requested: > - Wrap those four ImplementationManager.Load<T>() calls with #pragma warning disable CS0618 and #pragma warning restore CS0618 so the obsolete warning does not fail the build, but the calls remain. > - Keep the rest of the file untouched. > - Add a short comment explaining why the pragma is required (documentation states the calls are obsolete but they are still necessary at runtime). > > Desired replacement method: > > public static void PreStartup() > { > // ImplementationManager.Load<T>() is marked obsolete but is still required at runtime for explicit registration of DBMS implementations. > #pragma warning disable CS0618 // ImplementationManager.Load<T>() is obsolete but required > ImplementationManager.Load<MicrosoftSQLImplementation>(); > ImplementationManager.Load<MySqlImplementation>(); > ImplementationManager.Load<OracleImplementation>(); > ImplementationManager.Load<PostgreSqlImplementation>(); > #pragma warning restore CS0618 > } > > Commit message: "Silence CS0618 for ImplementationManager.Load calls in PreStartup while keeping required loads" > > PR title: "Silence obsolete warning for ImplementationManager.Load in PreStartup" > > Repository: jas88/RDMP </details> *This pull request was created as a result of the following prompt from Copilot chat.* > Replace the PreStartup() implementation in Rdmp.Core/Startup/Startup.cs to silence the obsolete-warning CS0618 around ImplementationManager.Load<T>() calls while keeping the calls intact. > > File to modify: Rdmp.Core/Startup/Startup.cs (ref: bbe80bc, BlobSha: edfec72) > > Current content around PreStartup (lines ~279-285): > > public static void PreStartup() > { > ImplementationManager.Load<MicrosoftSQLImplementation>(); > ImplementationManager.Load<MySqlImplementation>(); > ImplementationManager.Load<OracleImplementation>(); > ImplementationManager.Load<PostgreSqlImplementation>(); > } > > Change requested: > - Wrap those four ImplementationManager.Load<T>() calls with #pragma warning disable CS0618 and #pragma warning restore CS0618 so the obsolete warning does not fail the build, but the calls remain. > - Keep the rest of the file untouched. > - Add a short comment explaining why the pragma is required (documentation states the calls are obsolete but they are still necessary at runtime). > > Desired replacement method: > > public static void PreStartup() > { > // ImplementationManager.Load<T>() is marked obsolete but is still required at runtime for explicit registration of DBMS implementations. > #pragma warning disable CS0618 // ImplementationManager.Load<T>() is obsolete but required > ImplementationManager.Load<MicrosoftSQLImplementation>(); > ImplementationManager.Load<MySqlImplementation>(); > ImplementationManager.Load<OracleImplementation>(); > ImplementationManager.Load<PostgreSqlImplementation>(); > #pragma warning restore CS0618 > } > > Commit message: "Silence CS0618 for ImplementationManager.Load calls in PreStartup while keeping required loads" > > PR title: "Silence obsolete warning for ImplementationManager.Load in PreStartup" > > Repository: jas88/RDMP <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jas88 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated FAnsiSql.Legacy from 3.3.1 to 3.3.4.
Release notes
Sourced from FAnsiSql.Legacy's releases.
3.3.4
3.3.3
3.3.2
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)