Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 27, 2025

Updated FAnsiSql.Legacy from 3.3.1 to 3.3.4.

Release notes

Sourced from FAnsiSql.Legacy's releases.

3.3.4

3.3.3

3.3.2

Commits viewable in compare view.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

---
updated-dependencies:
- dependency-name: FAnsiSql.Legacy
  dependency-version: 3.3.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Oct 27, 2025
- [x] Review the current Startup.cs file and understand the PreStartup
method
- [x] Add #pragma warning disable CS0618 before the
ImplementationManager.Load calls
- [x] Add a comment explaining why the pragma is required
- [x] Add #pragma warning restore CS0618 after the calls
- [x] Build the project to ensure the change compiles correctly
- [x] Verify the change matches the desired replacement in the problem
statement

<!-- START COPILOT CODING AGENT SUFFIX -->



<details>

<summary>Original prompt</summary>

> Replace the PreStartup() implementation in
Rdmp.Core/Startup/Startup.cs to silence the obsolete-warning CS0618
around ImplementationManager.Load<T>() calls while keeping the calls
intact.
> 
> File to modify: Rdmp.Core/Startup/Startup.cs (ref:
bbe80bc, BlobSha:
edfec72)
> 
> Current content around PreStartup (lines ~279-285):
> 
> public static void PreStartup()
> {
>     ImplementationManager.Load<MicrosoftSQLImplementation>();
>     ImplementationManager.Load<MySqlImplementation>();
>     ImplementationManager.Load<OracleImplementation>();
>     ImplementationManager.Load<PostgreSqlImplementation>();
> }
> 
> Change requested:
> - Wrap those four ImplementationManager.Load<T>() calls with #pragma
warning disable CS0618 and #pragma warning restore CS0618 so the
obsolete warning does not fail the build, but the calls remain.
> - Keep the rest of the file untouched.
> - Add a short comment explaining why the pragma is required
(documentation states the calls are obsolete but they are still
necessary at runtime).
> 
> Desired replacement method:
> 
> public static void PreStartup()
> {
> // ImplementationManager.Load<T>() is marked obsolete but is still
required at runtime for explicit registration of DBMS implementations.
> #pragma warning disable CS0618 // ImplementationManager.Load<T>() is
obsolete but required
>     ImplementationManager.Load<MicrosoftSQLImplementation>();
>     ImplementationManager.Load<MySqlImplementation>();
>     ImplementationManager.Load<OracleImplementation>();
>     ImplementationManager.Load<PostgreSqlImplementation>();
>     #pragma warning restore CS0618
> }
> 
> Commit message: "Silence CS0618 for ImplementationManager.Load calls
in PreStartup while keeping required loads"
> 
> PR title: "Silence obsolete warning for ImplementationManager.Load in
PreStartup"
> 
> Repository: jas88/RDMP


</details>

*This pull request was created as a result of the following prompt from
Copilot chat.*
> Replace the PreStartup() implementation in
Rdmp.Core/Startup/Startup.cs to silence the obsolete-warning CS0618
around ImplementationManager.Load<T>() calls while keeping the calls
intact.
> 
> File to modify: Rdmp.Core/Startup/Startup.cs (ref:
bbe80bc, BlobSha:
edfec72)
> 
> Current content around PreStartup (lines ~279-285):
> 
> public static void PreStartup()
> {
>     ImplementationManager.Load<MicrosoftSQLImplementation>();
>     ImplementationManager.Load<MySqlImplementation>();
>     ImplementationManager.Load<OracleImplementation>();
>     ImplementationManager.Load<PostgreSqlImplementation>();
> }
> 
> Change requested:
> - Wrap those four ImplementationManager.Load<T>() calls with #pragma
warning disable CS0618 and #pragma warning restore CS0618 so the
obsolete warning does not fail the build, but the calls remain.
> - Keep the rest of the file untouched.
> - Add a short comment explaining why the pragma is required
(documentation states the calls are obsolete but they are still
necessary at runtime).
> 
> Desired replacement method:
> 
> public static void PreStartup()
> {
> // ImplementationManager.Load<T>() is marked obsolete but is still
required at runtime for explicit registration of DBMS implementations.
> #pragma warning disable CS0618 // ImplementationManager.Load<T>() is
obsolete but required
>     ImplementationManager.Load<MicrosoftSQLImplementation>();
>     ImplementationManager.Load<MySqlImplementation>();
>     ImplementationManager.Load<OracleImplementation>();
>     ImplementationManager.Load<PostgreSqlImplementation>();
>     #pragma warning restore CS0618
> }
> 
> Commit message: "Silence CS0618 for ImplementationManager.Load calls
in PreStartup while keeping required loads"
> 
> PR title: "Silence obsolete warning for ImplementationManager.Load in
PreStartup"
> 
> Repository: jas88/RDMP

<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: jas88 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant