Bump Microsoft.Bcl.AsyncInterfaces from 9.0.7 to 9.0.10 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb0c864 to
02971fd
Compare
Pull Request Test Coverage Report for Build 18910962960Details
💛 - Coveralls |
02971fd to
07ae4ac
Compare
jas88
added a commit
that referenced
this pull request
Oct 29, 2025
Remove CAST to Date which was stripping time component and causing timezone-sensitive test failures in RemoteDatabaseAttacherTests. Issue: - SqlHistoricalDataFilter was using CAST(column as Date) - This strips hours/minutes/seconds from datetime values - When test runs near midnight, causes off-by-one day errors - Test expects 3 rows but gets 2 due to date boundary issues Example failure: - withinDate = "2025-10-28 23:00:00" (1 hour ago, Oct 28) - CAST to Date = "2025-10-28" (time stripped) - DATEADD(DAY, -1, GETDATE()) = "2025-10-28" at midnight - Comparison: "2025-10-28" > "2025-10-28" = FALSE (row excluded) Fix: - Remove all CAST(column as Date) operations - Use datetime column directly for time-sensitive comparisons - Preserves full precision for accurate date filtering Affected cases: - Past24Hours, Past7Days, PastMonth, PastYear - SinceLastUse, Custom, DeltaReading This fixes CI failures in PR #39 and other dependabot PRs running RemoteDatabaseAttacherTests at various times of day. Tests affected: - TestRemoteDatabaseAttacherWithDateFilter(*, *, Past24Hours)
jas88
added a commit
that referenced
this pull request
Oct 29, 2025
Remove CAST to Date which was stripping time component and causing timezone-sensitive test failures in RemoteDatabaseAttacherTests. Issue: - SqlHistoricalDataFilter was using CAST(column as Date) - This strips hours/minutes/seconds from datetime values - When test runs near midnight, causes off-by-one day errors - Test expects 3 rows but gets 2 due to date boundary issues Example failure: - withinDate = "2025-10-28 23:00:00" (1 hour ago, Oct 28) - CAST to Date = "2025-10-28" (time stripped) - DATEADD(DAY, -1, GETDATE()) = "2025-10-28" at midnight - Comparison: "2025-10-28" > "2025-10-28" = FALSE (row excluded) Fix: - Remove all CAST(column as Date) operations - Use datetime column directly for time-sensitive comparisons - Preserves full precision for accurate date filtering Affected cases: - Past24Hours, Past7Days, PastMonth, PastYear - SinceLastUse, Custom, DeltaReading This fixes CI failures in PR #39 and other dependabot PRs running RemoteDatabaseAttacherTests at various times of day. Tests affected: - TestRemoteDatabaseAttacherWithDateFilter(*, *, Past24Hours)
jas88
added a commit
that referenced
this pull request
Oct 29, 2025
Remove CAST to Date which was stripping time component and causing timezone-sensitive test failures in RemoteDatabaseAttacherTests. Issue: - SqlHistoricalDataFilter was using CAST(column as Date) - This strips hours/minutes/seconds from datetime values - When test runs near midnight, causes off-by-one day errors - Test expects 3 rows but gets 2 due to date boundary issues Example failure: - withinDate = "2025-10-28 23:00:00" (1 hour ago, Oct 28) - CAST to Date = "2025-10-28" (time stripped) - DATEADD(DAY, -1, GETDATE()) = "2025-10-28" at midnight - Comparison: "2025-10-28" > "2025-10-28" = FALSE (row excluded) Fix: - Remove all CAST(column as Date) operations - Use datetime column directly for time-sensitive comparisons - Preserves full precision for accurate date filtering Affected cases: - Past24Hours, Past7Days, PastMonth, PastYear - SinceLastUse, Custom, DeltaReading This fixes CI failures in PR #39 and other dependabot PRs running RemoteDatabaseAttacherTests at various times of day. Tests affected: - TestRemoteDatabaseAttacherWithDateFilter(*, *, Past24Hours)
jas88
added a commit
that referenced
this pull request
Oct 29, 2025
Remove CAST to Date which was stripping time component and causing timezone-sensitive test failures in RemoteDatabaseAttacherTests. Issue: - SqlHistoricalDataFilter was using CAST(column as Date) - This strips hours/minutes/seconds from datetime values - When test runs near midnight, causes off-by-one day errors - Test expects 3 rows but gets 2 due to date boundary issues Example failure: - withinDate = "2025-10-28 23:00:00" (1 hour ago, Oct 28) - CAST to Date = "2025-10-28" (time stripped) - DATEADD(DAY, -1, GETDATE()) = "2025-10-28" at midnight - Comparison: "2025-10-28" > "2025-10-28" = FALSE (row excluded) Fix: - Remove all CAST(column as Date) operations - Use datetime column directly for time-sensitive comparisons - Preserves full precision for accurate date filtering Affected cases: - Past24Hours, Past7Days, PastMonth, PastYear - SinceLastUse, Custom, DeltaReading This fixes CI failures in PR #39 and other dependabot PRs running RemoteDatabaseAttacherTests at various times of day. Tests affected: - TestRemoteDatabaseAttacherWithDateFilter(*, *, Past24Hours)
Owner
|
@dependabot rebase |
--- updated-dependencies: - dependency-name: Microsoft.Bcl.AsyncInterfaces dependency-version: 9.0.10 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
07ae4ac to
5e7f334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Microsoft.Bcl.AsyncInterfaces from 9.0.7 to 9.0.10.
Release notes
Sourced from Microsoft.Bcl.AsyncInterfaces's releases.
9.0.10
Release
What's Changed
Full Changelog: dotnet/runtime@v9.0.9...v9.0.10
9.0.9
Release
What's Changed
Full Changelog: dotnet/runtime@v9.0.8...v9.0.9
9.0.8
Release
What's Changed
InvalidOperationExceptiononTestOutputHelperlogging. by @ilonatommy in [release/9.0-staging][wbt] PreventInvalidOperationExceptiononTestOutputHelperlogging. dotnet/runtime#116916Ping_TimedOut_*tests by @github-actions[bot] in [release/9.0-staging] HardenPing_TimedOut_*tests dotnet/runtime#116630Full Changelog: dotnet/runtime@v9.0.7...v9.0.8
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)