Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implementing Raft #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
May 16, 2025
Merged

Implementing Raft #37

merged 63 commits into from
May 16, 2025

Conversation

@jathurchan
Copy link
Owner

@jathurchan jathurchan commented Apr 29, 2025 •
edited
Loading

closes #9

@jathurchan jathurchan self-assigned this Apr 29, 2025
@codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.09193% with 485 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
raft/snapshot.go 81.63% 107 Missing and 23 partials ⚠️
raft/replication.go 89.00% 109 Missing and 20 partials ⚠️
raft/network.go 87.69% 70 Missing and 15 partials ⚠️
raft/raft.go 89.04% 47 Missing and 9 partials ⚠️
raft/election.go 94.14% 24 Missing and 8 partials ⚠️
raft/log.go 94.12% 22 Missing and 10 partials ⚠️
raft/builder.go 90.05% 12 Missing and 7 partials ⚠️
raft/metrics.go 94.87% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jathurchan jathurchan force-pushed the 9-implement-raft branch 3 times, most recently from 2b1ebc7 to 9c2b802 Compare April 30, 2025 14:02
@jathurchan jathurchan force-pushed the 9-implement-raft branch 3 times, most recently from 5d494d4 to 1a00bf1 Compare May 6, 2025 07:50
@jathurchan jathurchan linked an issue May 6, 2025 that may be closed by this pull request
[Raft/NetworkManager] Refactor metric labels and values to use typed constants #43
Open
@jathurchan jathurchan removed a link to an issue May 6, 2025
[Raft/NetworkManager] Refactor metric labels and values to use typed constants #43
Open
This was referenced May 6, 2025
Open
Open
Open
Open
@jathurchan jathurchan mentioned this pull request May 12, 2025
Open
jathurchan added 23 commits May 15, 2025 22:37
@jathurchan
Added unit tests for methods in raft/clock.go
766e1ef
@jathurchan
Added unit tests for NoOpMetrics
f639d0a
@jathurchan
fix: Introduced metrics.ObserveTerm
40b0a03
@jathurchan
feat: Added unit tests for stateManager (100%)
d1e63cb
@jathurchan
feat: Improved RaftBuilder and added unit tests
344efe8
@jathurchan
fix: Improved mockStorage
8a2e20f
@jathurchan
fix: Renamed tests for for RaftBuilder
ab517bb
@jathurchan
feat: Introduced mockMetrics
12f530b
@jathurchan
fix: Fixed logManager methods and added tests
d4fa130
@jathurchan
test: Added unit tests for logManager
651543d
@jathurchan
fix: Fixed processPreVoteReply and improved testability
6eb18d9
@jathurchan
test: Added tests for electionManager
3d4e2cd
@jathurchan
test: Added new mocks and improved current ones
e686c5b
@jathurchan
test: Improved mocks and adapted electionManager tests
c515315
@jathurchan
fix: Improved triggerCommitCheck
e1ce5bc
@jathurchan
test: Added tests for replicationManager methods
d4d33de
@jathurchan
fix: Fixed Stop of replicationManager
dfba771
@jathurchan
fix: Fixed snapshotManager and added tests
24f1c51
@jathurchan
test: Added unit tests for methods in rand.go
272db35
@jathurchan
test: Improved mocks
995b168
@jathurchan
test: Fixed networkManager and added tests
d6f1c1a
@jathurchan
test: Added tests for Raft implementation
a85ddcc
@jathurchan
fix: Fixed unit test workflow for raft package
1ad75aa
@jathurchan jathurchan marked this pull request as ready for review May 15, 2025 20:50
@jathurchan jathurchan mentioned this pull request May 16, 2025
Open
mathusanm6
mathusanm6 approved these changes May 16, 2025
View reviewed changes
Copy link
Collaborator

@mathusanm6 mathusanm6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. LGTM!

@jathurchan jathurchan merged commit c0718db into main May 16, 2025
2 checks passed
@jathurchan jathurchan deleted the 9-implement-raft branch May 16, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathusanm6 mathusanm6 mathusanm6 approved these changes

@Patrice-Zhou Patrice-Zhou Awaiting requested review from Patrice-Zhou

Assignees

@jathurchan jathurchan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Raft

2 participants

@jathurchan @mathusanm6