``[noref] Fix with claude #767
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 87425f8 in 2 minutes and 8 seconds. Click for details.
- Reviewed
383lines of code in2files - Skipped
2files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. client.go:55
- Draft comment:
Avoid double deferring Close; let the caller manage response.Body closing. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. client.go:35
- Draft comment:
Consider setting a timeout on the http.Client to avoid hanging requests. - Reason this comment was not posted:
Comment was on unchanged code.
3. shift.go:84
- Draft comment:
Reuse the Bl3Client's HTTP client in GetFullShiftCodeList instead of creating a new one. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. shift.go:94
- Draft comment:
Avoid using 'json' as a variable name to prevent shadowing the encoding/json package. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
5. client.go:221
- Draft comment:
The error message "SHiFT login service is temporarily unavailable (503)..." uses an inconsistent capitalization compared to the rest of the code (e.g. "shift.gearboxsoftware.com"). Consider using consistent capitalization (e.g., "SHIFT" or "shift") for clarity. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% This is a very minor stylistic suggestion about capitalization in an error message. SHiFT appears to be a brand name and may have official capitalization. The inconsistency doesn't impact functionality or code quality. This seems like the kind of nitpicky comment we should avoid. The comment could be valid if there's a strong style guide requirement for consistent capitalization. The current mixed capitalization could be slightly confusing to users. Brand names often have specific capitalization that differs from normal text. This is a user-facing error message where the exact capitalization of SHiFT is not critical to understanding. Delete this comment as it's too minor and focuses on non-functional aspects of an error message string.
Workflow ID: wflow_9dy29EacmEw5bxYl
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
| // Extract session cookie from response | ||
| cookies := loginRes.Header.Values("Set-Cookie") | ||
| for _, cookie := range cookies { | ||
| if len(cookie) >= 12 && cookie[:12] == "_session_id=" { |
There was a problem hiding this comment.
Use strings.HasPrefix for cookie prefix check instead of manual slicing.
Suggested change
| if len(cookie) >= 12 && cookie[:12] == "_session_id=" { | |
| if strings.HasPrefix(cookie, "_session_id=") { |
| // If it's a redirect to somewhere else, it's likely successful | ||
| if location != "" { | ||
| // Extract session cookie from response | ||
| cookies := loginRes.Header.Values("Set-Cookie") |
There was a problem hiding this comment.
Refactor duplicate session cookie extraction logic into a helper function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update SHiFT client to handle CSRF tokens, manual redirects, and reflect API discontinuation.
Login()inclient.goto handle CSRF tokens and improve error handling for login failures.RedeemShiftCode()inshift.goto return an error message indicating the discontinuation of the 2K Borderlands API.GetCodePlatforms()andGetShiftPlatforms()inshift.go.CheckRedirectfunction inNewHttpClient()inclient.goto handle redirects manually.NewHttpClient()to mimic a real browser.getResponse()inclient.gofor nil responses.NewBl3Client()inclient.gofor reading and parsingconfig.json.This description was created by
for 87425f8. You can customize this summary. It will automatically update as commits are pushed.