marshal: replace github.com/ghodss/yaml with gopkg.in/yaml.v2
#347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. Since we are only using the `JSONToYAML` from `github.com/ghodss/yaml`, we can write the code ourselves and drop an extra dependency. Signed-off-by: Eng Zer Jun <[email protected]>
jaypipes
reviewed
Jul 14, 2023
go.mod
Outdated
| github.com/jaypipes/pcidb v1.0.0 | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/spf13/cobra v0.0.3 | ||
| gopkg.in/yaml.v2 v2.4.0 |
There was a problem hiding this comment.
How about gopkg.in/yaml.v3 instead? :)
There was a problem hiding this comment.
Updated to gopkg.in/yaml.v3
Signed-off-by: Eng Zer Jun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
The
github.com/ghodss/yamlpackage is no longer actively maintained. There are numerous inquiries about the project's status on its issue tracker: https://github.com/ghodss/yaml/issues.Since we are only using the
JSONToYAMLfromgithub.com/ghodss/yaml, we can implement the code ourselves 1 and remove an extra dependency.Alternatively, we can replace
github.com/ghodss/yamlwithsigs.k8s.io/yaml, which is a permanent fork currently maintained by Kubernetes SIG. Please let me know if you prefer using a package for YAML unmarshalling, and I will gladly update this pull request.Footnotes
https://github.com/ghodss/yaml/blob/0ca9ea5df5451ffdf184b4428c902747c2c11cd7/yaml.go#L45-L61 ↩