overhaul ghw-snapshot tool #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a675db to
c703760
Compare
This is the first step in actually overhauling the ghw library's context package and moving to a more standard `context.Context` usage. In order to standardize the context usage, we needed to change the way that the ghw-snapshot functionality worked to manually construct a `pkg/context.Context` and call `pkg/context.Context:Do()` while reading the snapshot tarball. In order to do that, I created a new `ghw-snapshot read` command that accepts a single argument to the snapshot tarball path to read: ``` ➜ ghw git:(overhaul-snapshot) ✗ GHW_DISABLE_WARNINGS=1 go run cmd/ghw-snapshot/main.go read testdata/snapshots/linux-amd64-intel-xeon-L5640.tar.gz block storage (8 disks, 723GB physical storage) cpu (2 physical packages, 12 cores, 24 hardware threads) gpu (0 graphics cards) memory (66GB physical, 63GB usable) net (0 NICs) topology NUMA (2 nodes) chassis type=unknown vendor=unknown version=unknown bios vendor=unknown version=unknown baseboard vendor=unknown version=unknown product=unknown product family=unknown name=unknown vendor=unknown sku=unknown version=unknown PCI (82 devices) ➜ ghw git:(overhaul-snapshot) ✗ GHW_DISABLE_WARNINGS=1 go run cmd/ghw-snapshot/main.go read testdata/snapshots/linux-amd64-amd-ryzen-1600.tar.gz block storage (8 disks, 3TB physical storage) cpu (1 physical package, 6 cores, 12 hardware threads) gpu (1 graphics card) memory (32GB physical, 32GB usable) net (4 NICs) topology NUMA (0 nodes) chassis type=unknown vendor=unknown version=unknown bios vendor=unknown version=unknown baseboard vendor=unknown version=unknown product=unknown product family=unknown name=unknown vendor=unknown sku=unknown version=unknown PCI (43 devices) ``` A followup series of patches will make the aforementioned changes to `pkg/context` and remove the `pkg/context.Context:Do()` method and put that entirely in the `cmd/ghw-snapshot/command/read.go` file which is the only place we actually use it. Signed-off-by: Jay Pipes <[email protected]>
c703760 to
804ce35
Compare
|
@ffromani what do you think of this one? :) |
ffromani
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in actually overhauling the ghw library's context package and moving to a more standard
context.Contextusage. In order to standardize the context usage, we needed to change the way that the ghw-snapshot functionality worked to manually construct apkg/context.Contextand callpkg/context.Context:Do()while reading the snapshot tarball.In order to do that, I created a new
ghw-snapshot readcommand that accepts a single argument to the snapshot tarball path to read:A followup series of patches will make the aforementioned changes to
pkg/contextand remove thepkg/context.Context:Do()method and put that entirely in thecmd/ghw-snapshot/command/read.gofile which is the only place we actually use it.