fix: only mark non-rotational HDDs as SSD #422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Starting with RHCOS 4.19 (possibly other newer kernels), optical drives and some loop devices report rotational=0, causing them to be misclassified as SSD.
RHCOS 4.19+:
RHCOS <= 4.18:
The fix
Only promote devices to SSD when they're actually HDD type devices
This is likely a general kernel behavior change, not RHCOS only, so the fix benefits all Linux distributions.
Possible impact
sr0 stays ODD (fixes the core issue)
loop stays Virtual
Non-rotational sd*/vd*/hd*/xvd* still can be promoted to SSD
nvme*/mmc* unchanged