do not error when $HOME not set #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
candlerb
reviewed
Aug 31, 2025
types/default.go
Outdated
| // https://github.com/jaypipes/pcidb/issues/38 | ||
| if _, ok := os.LookupEnv("HOME"); !ok { | ||
| return "" | ||
| } |
There was a problem hiding this comment.
IMO this defeats the whole object of using os.UserHomeDir(), since the point of it is that it's platform independent - different platforms use different env vars for home.
Since the only error which UserHomeDir can return is if the required env variable is not set, I think a better solution would be simply:
hdir, err := os.UserHomeDir()
if err != nil {
return ""
}
(that is, just remove the printing of the error)
4187bbe to
01517ae
Compare
In calculating the default cache path, we were using the `os.UserHomeDir()` function to get the user's home directory. This function differs from the behaviour of mitchellh/go-homedir in that it errors out on Linux if `$HOME` is not set. This caused issues in certain environments and so this PR simply returns an empty string when `$HOME` is unset and now returns an error only during pci.ids DB file discovery if search paths yields an empty slice AND cache path is empty AND network fetch is enabled. Issue #38 Signed-off-by: Jay Pipes <[email protected]>
01517ae to
0aa295c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In calculating the default cache path, we were using the
os.UserHomeDir()function to get the user's home directory. This function differs from the behaviour of mitchellh/go-homedir in that it errors out on Linux if$HOMEis not set.This caused issues in certain environments and so this PR simply returns an empty string when
$HOMEis unset and now returns an error only during pci.ids DB file discovery if search paths yields an empty slice AND cache path is empty AND network fetch is enabled.Issue #38