Fixes #109 fn overload on task promise::return_void bug #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return_void() overload was throwing, but this is incorrect per the standard, it should effectively do nothing. This was an error on my part since I over- loaded the non-void task<T> return_value(T) -> void and return_value() -> T fns. This overload isn't possible with the void versions since the signature is identical, thus the bug caused the compiler's coroutine version to re-throw exceptions at the wrong time.
jbaldwin
commented
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return_void() overload was throwing, but this is
incorrect per the standard, it should effectively do
nothing. This was an error on my part since I over-
loaded the non-void task return_value(T) -> void
and return_value() -> T fns. This overload isn't
possible with the void versions since the signature
is identical, thus the bug caused the compiler's coroutine
version to re-throw exceptions at the wrong time.