Better MSVC support #184
Merged
Better MSVC support #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Since you are now starting to add specific MSVC flags to the cmake files can you add a GitHub action that compiles with MSVC and runs the tests please? |
Contributor
Author
|
I'd be happy to. However, tests will fail until this and the other PRs are merged. Is that OK? |
Merged
Contributor
Author
I went ahead and created #188. |
Owner
|
Cool #188 works, we can work towards getting that to pass with each PR. |
jbaldwin
previously approved these changes
Oct 18, 2023
Update: Require newer CMake version to properly merge warning flags. Otherwise, cl complains that both /W3 (the default warning level) and /W4 are passed. Newer CMake fixes this.
…cified in GCC-specific code). Fix: Add MSVC flags to produce more warnings.
Contributor
Author
|
Fantastic! |
Owner
|
Sorry, looks like this has a conflict now with the other two PRs that just merged, would you mind resolving them? |
# Conflicts: # CMakeLists.txt # test/CMakeLists.txt
Contributor
Author
|
No problem, done! |
jbaldwin
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds warning flags for MSVC and cleans up minor complains when it's passed GCC-only flags.