C#13: Add the "allow byref-like" anti-constraint #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `AllowsByRefLike` flag to `GenericParameterAttributes` which, unlike the others, is an anti-constraint (i.e. it removes restrictions rather than adding them) added in C# 13. Because of this, `AllowsByRefLike` was chosen as the corresponding bool property on `GenericParameter` (instead of `HasAllowByRefLineConstraint`; the constant also does not include `Constraint` in its name). At the same time, it adds the `NoSpecialConstraint` flag and a corresponding `HasNoSpecialConstraint` property.
Contributor
Author
|
Hmm, looks like it's already there; could have sworn I updated my fork. |
Contributor
Author
|
Right, still keeping this PR because:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
AllowsByRefLikeflag toGenericParameterAttributeswhich, unlike the others, is an anti-constraint (i.e. it removes restrictions rather than adding them) added in C# 13. Because of this,AllowsByRefLikewas chosen as the corresponding bool property onGenericParameter(instead ofHasAllowByRefLineConstraint; the constant also does not includeConstraintin its name).At the same time, it adds the
NoSpecialConstraintflag and a correspondingHasNoSpecialConstraintproperty.Reference: corresponding constants in the CLR code: https://github.com/dotnet/runtime/blob/9daa4b41eb9f157e79eaf05e2f7451c9c8f6dbdc/src/coreclr/inc/corhdr.h#L850