-
-
Notifications
You must be signed in to change notification settings - Fork 696
fix(shim): improve resolve_symlink for Windows #5361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7b31f72 to
4ffcddc
Compare
|
I also found this issue, but my fix was bit diferent: I don't think it makes sense using or there because on linux it should always be a link and on windows it should always be a file. |
|
Looking at the surrounding code it seems that on windows sometimes real links are created. So maybe my solution isn't fully correct. Maybe on windows check for both file and link and on other systems only check for links? |
|
Ah, but if a real symlink is found on windows we shouldn't do |
|
Why is this a draft PR? Should I create a PR with my proposed changes? |
|
Since the tests failed, I will try again today. |
be8ece9 to
d7aae51
Compare
d7aae51 to
e8a06bf
Compare
|
The previous error was caused by the incorrect use of |
f46cc93 to
db16899
Compare
c4f6ab5 to
df7f5d0
Compare
|
This pr is ready to merge |
### π Features - **(registry)** add wash by [@jtakakura](https://github.com/jtakakura) in [#5386](#5386) ### π Bug Fixes - **(aqua)** parse consecutive pipes in aqua templates by [@risu729](https://github.com/risu729) in [#5385](#5385) - **(aqua)** use versions list to install correct version by [@risu729](https://github.com/risu729) in [#5371](#5371) - **(registry)** talosctl use aqua by [@mangkoran](https://github.com/mangkoran) in [#5348](#5348) - **(registry)** use aqua backend for watchexec by [@risu729](https://github.com/risu729) in [#5390](#5390) - **(shim)** improve resolve_symlink for Windows by [@qianlongzt](https://github.com/qianlongzt) in [#5361](#5361) - add compression-zip-deflate feature on self_update crate for windows target by [@roele](https://github.com/roele) in [#5391](#5391) - suppress hint on 'cargo search mise' command by [@roele](https://github.com/roele) in [#5400](#5400) ### π Documentation - Fix typo in README.md - Install mise by [@cytsai1008](https://github.com/cytsai1008) in [#5366](#5366) - Document trivial task syntax by [@JayBazuzi](https://github.com/JayBazuzi) in [#5352](#5352) ### π§ͺ Testing - **(registry)** fix vultr test by [@risu729](https://github.com/risu729) in [#5372](#5372) ### π¦οΈ Dependency Updates - update autofix-ci/action action to v1.3.2 by [@renovate[bot]](https://github.com/renovate[bot]) in [#5377](#5377) - update docker/setup-buildx-action digest to e468171 by [@renovate[bot]](https://github.com/renovate[bot]) in [#5376](#5376) ### Chore - update expr-lang crate to v0.3.2 by [@risu729](https://github.com/risu729) in [#5364](#5364) - show curl error by [@jdx](https://github.com/jdx) in [729aa4a](729aa4a) - fix latest version fetch by [@jdx](https://github.com/jdx) in [729aadc](729aadc) - update vfox.rs crate to v1.0.3 by [@risu729](https://github.com/risu729) in [#5393](#5393) - updated deps by [@jdx](https://github.com/jdx) in [#5403](#5403) ### Ci - use cargo info to retrieve latest mise version by [@risu729](https://github.com/risu729) in [#5401](#5401) ### New Contributors - @jtakakura made their first contribution in [#5386](#5386) - @JayBazuzi made their first contribution in [#5352](#5352) - @cytsai1008 made their first contribution in [#5366](#5366)
#5254
#5241