Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yjoer
Copy link
Contributor

@yjoer yjoer commented Jun 10, 2025

I had matching_regex landed on UBI in houseabsolute/ubi#122. This change enables passing the option from the mise config to the backend.

Closes #5318

@yjoer
Copy link
Contributor Author

yjoer commented Jun 10, 2025

The builds are failing because os_str_display is stabilized in Rust 1.87 and an earlier version is used in the CI.

@jdx
Copy link
Owner

jdx commented Jun 12, 2025

1.87 is way too new to supportβ€”it's less than a month old. @autarch would it be possible to use alternate syntax to support somewhat older rust releases? this would be a problem for distros that have somewhat old rust versions?

@jdx
Copy link
Owner

jdx commented Jun 12, 2025

bugbot run verbose=true

@cursor
Copy link

cursor bot commented Jun 12, 2025

bugbot is starting with request id serverGenReqId_382335eb-4473-4cc0-ae46-a947fa64928f

@cursor
Copy link

cursor bot commented Jun 12, 2025

🚨 BugBot couldn't run

Pull requests from forked repositories are not yet supported (requestId: serverGenReqId_382335eb-4473-4cc0-ae46-a947fa64928f).

@autarch
Copy link
Contributor

autarch commented Jun 13, 2025

1.87 is way too new to supportβ€”it's less than a month old. @autarch would it be possible to use alternate syntax to support somewhat older rust releases? this would be a problem for distros that have somewhat old rust versions?

Sure, but I don't know exactly what thing I'm using that's 1.87-specific.

@autarch
Copy link
Contributor

autarch commented Jun 13, 2025

Oh, I guess it's using {} with an OsStr?

@autarch
Copy link
Contributor

autarch commented Jun 13, 2025

Looks like this repo targets 1.85, so I'll do the same for the ubi crate.

@jdx
Copy link
Owner

jdx commented Jun 13, 2025

yeah I don't have a specific guideline around this but try not to bump it unless I need to, though I try to keep it at least 6 months

@yjoer
Copy link
Contributor Author

yjoer commented Jun 13, 2025

The builds are passing now πŸ₯³

Thanks @jdx and @autarch

source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "fabe6324e908f85a1c52063ce7aa26b68dcb7eb6dbc83a2d148403c9bc3eba50"
dependencies = [
"aes",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is strange but I assume it's fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ubi 0.7.0, I started adding default-features = false to most dependency declarations. This eliminated a bunch of transitive dependencies that weren't being used.

@jdx jdx merged commit f41afcf into jdx:main Jun 13, 2025
18 checks passed
jdx pushed a commit that referenced this pull request Jun 13, 2025
### πŸš€ Features

- support matching_regex from the ubi backend by
[@yjoer](https://github.com/yjoer) in
[#5320](#5320)

### πŸ› Bug Fixes

- **(aqua)** parse templates in version_filter by
[@risu729](https://github.com/risu729) in
[#5341](#5341)
- **(registry)** use extract_all for docker-slim by
[@risu729](https://github.com/risu729) in
[#5342](#5342)

### 🚜 Refactor

- **(getting-started)** update powershell profile instructions by
[@Armaldio](https://github.com/Armaldio) in
[#5340](#5340)

### πŸ“¦οΈ Dependency Updates

- update docker/build-push-action digest to 2634353 by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#5338](#5338)
- update jdx/mise-action digest to 13abe50 by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#5339](#5339)

### New Contributors

- @yjoer made their first contribution in
[#5320](#5320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants