Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(lib): remove differt.utils.minimize #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

feat(lib): remove differt.utils.minimize #291

merged 1 commit into from
Jul 15, 2025

Conversation

@jeertmans
Copy link
Owner

@jeertmans jeertmans commented Jul 15, 2025

As motivated #283

@github-actions github-actions bot added documentation Improvements or additions to documentation python Changes Python code tests Changes tests labels Jul 15, 2025
@codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.16%. Comparing base (65da1ba) to head (72454fb).
⚠️ Report is 51 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
- Coverage   82.37%   82.16%   -0.22%     
==========================================
  Files          32       32              
  Lines        3036     2999      -37     
==========================================
- Hits         2501     2464      -37     
  Misses        535      535

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added ci Continuous integration (tests, lints, ...) visualization Related to visualization utilities dependencies Related to the project dependencies labels Jul 15, 2025
@jeertmans jeertmans merged commit 1690855 into main Jul 15, 2025
58 of 70 checks passed
@jeertmans jeertmans deleted the remove-minimize branch July 15, 2025 16:08
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 15, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #291 will degrade performances by 99.79%

Comparing remove-minimize (72454fb) with main (65da1ba)

Summary

⚡ 2 improvements
❌ 3 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ test_compute_paths_in_simple_street_canyon_scene[True-20000-0] 4.3 ms 743.3 ms -99.42%
❌ test_compute_paths_in_simple_street_canyon_scene[True-20000-1] 4.7 ms 2,209.4 ms -99.79%
⚡ test_compute_paths_in_simple_street_canyon_scene[True-20000-2] 2,299.3 ms 20.1 ms ×110
❌ test_compute_paths_in_simple_street_canyon_scene[True-None-0] 553.7 ms 808.5 ms -31.51%
⚡ test_jitted_compute_paths[True] 2.2 s 1.9 s +15.85%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci Continuous integration (tests, lints, ...) dependencies Related to the project dependencies documentation Improvements or additions to documentation python Changes Python code tests Changes tests visualization Related to visualization utilities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeertmans