Make the Octokit client more configurable. #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parkr how would a user configure this? |
|
@benbalter By setting the relevant environment variables. |
|
Ahh, so what's descibed in https://github.com/jekyll/github-metadata#overrides isn't accurate today? |
|
@benbalter if you set PAGES_API_URL, octokit wont use it without this patch. You also have to set the OCTOKIT_API_ENDPONT environment variable. |
|
@jekyllbot: merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, it only points to https://api.github.com, but it should be configurable for GitHub Enterprise to point to other API and Web endpoints.
/cc @jekyll/gh-pages @brandonblack