Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Crunch09
Copy link
Member

Hi,
this uses Octokit::Client::Releases#latest_release and fixes #80 .

end

def latest_release_url
"#{releases_url}/latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be latest_release.url?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean remove latest_release_url because as i just saw url is already included in the payload from github so the user could write {{ site.github.latest_release.url }} ? Or do you mean calling (if possible) latest_release.url instead of "#{releases_url}/latest" on this line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or do you mean calling (if possible) latest_release.url instead of "#{releases_url}/latest" on this line?

This. Meaning can we call the url method of the latest_release object, rather than constructing the URL ourselves?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification! Just updated to use the latest_release object (hash).

@benbalter
Copy link
Contributor

@jekyllbot: merge

@jekyllbot jekyllbot merged commit 48a2971 into jekyll:master Jul 17, 2017
jekyllbot added a commit that referenced this pull request Jul 17, 2017
@benbalter
Copy link
Contributor

Thanks @Crunch09! Sorry for the delay in merging!

@Crunch09
Copy link
Member Author

No worries! Thank you 👍

@Crunch09 Crunch09 deleted the latest_release branch July 17, 2017 23:26
@jekyll jekyll locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add site.github.releases.latest

3 participants