-
Couldn't load subscription status.
- Fork 152
add latest_release and latest_release_url
#88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| end | ||
|
|
||
| def latest_release_url | ||
| "#{releases_url}/latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be latest_release.url?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean remove latest_release_url because as i just saw url is already included in the payload from github so the user could write {{ site.github.latest_release.url }} ? Or do you mean calling (if possible) latest_release.url instead of "#{releases_url}/latest" on this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or do you mean calling (if possible) latest_release.url instead of "#{releases_url}/latest" on this line?
This. Meaning can we call the url method of the latest_release object, rather than constructing the URL ourselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification! Just updated to use the latest_release object (hash).
4dc42f5 to
f634e86
Compare
|
@jekyllbot: merge |
|
Thanks @Crunch09! Sorry for the delay in merging! |
|
No worries! Thank you 👍 |
Hi,
this uses Octokit::Client::Releases#latest_release and fixes #80 .