Detect whether the client is connected to the internet. Only allow client calls if connected. #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient calls if connected.
4 tasks
|
@benbalter What do you think of the overall approach, here? |
benbalter
approved these changes
Aug 7, 2017
lib/jekyll-github-metadata/client.rb
Outdated
| end | ||
|
|
||
| def save_from_errors(default = false) | ||
| Jekyll::GitHubMetadata.log :warn, "No internet connection." unless internet_connected? |
There was a problem hiding this comment.
I'd add something like "GitHub metadata may be missing or incorrect".
|
@jekyllbot: merge +minor. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still very WIP, but this fixes #82.