Don't double-process the site.github namespace. #95
Conversation
|
|
||
| def generate(site) | ||
| if defined?(@_already_generated) | ||
| Jekyll::GitHubMetadata.log :debug, "Nothing left to do!" |
There was a problem hiding this comment.
We already are exposing users to unnecessary friction with unclear output, I'd suggest making it clear what's going on here.
There was a problem hiding this comment.
Agreed – I'm just going to nix it.
| attr_reader :site | ||
|
|
||
| def generate(site) | ||
| if defined?(@_already_generated) |
There was a problem hiding this comment.
Could we hook into after_init instead?
There was a problem hiding this comment.
after_init was introduced only a few versions ago so this would stop working for older versions. Probably fine, but just calling that out.
In the GitHub Pages gem, we call the configuration reset in after_reset, which is called towards the top. Does that seem OK?
|
Is it possible to tests this? |
14f143c to
ba830fd
Compare
|
@benbalter Can you please take another look?
Uhhhh I guess call it twice for the same site and make sure it doesn't call anything? |
| end | ||
|
|
||
| Jekyll::Hooks.register :site, :after_reset do |site| | ||
| Jekyll::GitHubMetadata::SiteGitHubMunger.munge(site) |
There was a problem hiding this comment.
Would after_init save us from having to check if we've already processes it (since it only fires once)?
|
Using |
|
@jekyllbot: merge |
Should fix #93 (comment)