Allow user values to override drop-determined values #110
Conversation
|
@benbalter FWIW I just did a test with this branch and it does still output the drop value from GitHub, not the one from the local config file, even with the switch of the arguments of Here's a link to the build preview, you can see that the link Happy to help debug you this. |
|
@DirtyF backported (forward-ported?) jekyll/jekyll#6338 via 7a97ed0. Let me know if things work as expected now? |
| drop | ||
| when Hash | ||
| Jekyll::Utils.deep_merge_hashes(site.config["github"], drop) | ||
| Jekyll::Utils.deep_merge_hashes(drop, site.config["github"]) |
There was a problem hiding this comment.
Flipping this may have some unintended consequences (because people expect the opposite) so we should be prepared for upset users.
|
@benbalter the issue is not resolved in my case |
|
@DirtyF see jekyll/jekyll#6338 (comment). Mind giving it one more try? (I tested locally with a test site and it worked as expected). |
|
Tested locally and go the following (expected) output: <footer>
<p>Une correction à apporter ? <a href="https://github.com//edit/master/_posts/2017-08-27-securite-psychologique.md">Éditez cet article</a>.</p>
</footer> |
|
@jekyllbot: merge +minor. |
Via #108 (comment), it appears user-supplied
site.githubvalues are being overwritten by drop-supplied values.It appears in 54942a4#diff-165b64b2f6bce98447b6c550f3205ad9L26, the order of the arguements passed to
Jekyll::Utils.deep_merge_hasheswere reversed since the right overrides the left value.This PR adds failing tests via a7d2b4b to ensure
site.githubis set to the expected value given different user-supplied inputs forsite.githubwith d36d1af reversing the order of the arguments./cc @DirtyF