More easily customizable CSS #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirtyF
approved these changes
Apr 7, 2017
Contributor
Author
|
@jekyllbot: merge +minor. |
Contributor
Author
|
Thanks @benbalter! |
domingohui
pushed a commit
to domingohui/minima
that referenced
this pull request
Apr 14, 2017
Merge pull request 117
domingohui
pushed a commit
to domingohui/minima
that referenced
this pull request
Apr 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate approach to #86 which mirrors the approach we take on all the https://github.com/pages-themes themes.
The idea being, the default CSS file includes only an @import statement with the themes name, and all defaults and imports exist in the
_sassdirectory.That way a novice user can simply copy the
assets/style.scssfile (or write the one line themself) and add any custom css after the import statement.The variable defaults already exist in
_sass/minima.scssand are duplicative (and confusing/overly complex IMHO).