Handle parsing for localised value formats#163
Merged
jenetics merged 1 commit intojenetics:releases/r3.0.1from Apr 11, 2022
raynigon:master
Merged
Handle parsing for localised value formats#163jenetics merged 1 commit intojenetics:releases/r3.0.1from raynigon:master
jenetics merged 1 commit intojenetics:releases/r3.0.1from
raynigon:master
Conversation
Contributor
Author
|
@jenetics I think this is only a Quick Fix. Until then, i added JitPack support which will be removed for the PR with the correct solution. |
jenetics
requested changes
Apr 10, 2022
Owner
jenetics
left a comment
There was a problem hiding this comment.
We should also fix the root cause and disable the number grouping in the GPX.Writer. Line 1491 - 1493.
final var format = NumberFormat.getNumberInstance(ENGLISH);
format.setMaximumFractionDigits(_maximumFractionDigits);
format.setGroupingUsed(false);
Owner
|
And thank you for the fix 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When serializing a GPX file, the decimal values are formatted with english locale.
This leads to problems when deserializing the data.
The length cannot be parsed if the value exceeds 1000.0
Fixes #162
Type of change
Please delete options that are not relevant.
How Has This Been Tested?