Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@muellerj
Copy link

Move the template descriptions into their ./lib/tilt/*.rb files and link to these from the README

@muellerj
Copy link
Author

muellerj commented Sep 23, 2025

@jeremyevans please have a look if this is the direction you were intending. I haven't quite finished looking over all the template docs, but I would ultimately like to move everything out of TEMPLATES.md (and delete the latter subsequently).

I'll squash everything into a single commit unless you want small granular commits?

@muellerj
Copy link
Author

In particular, I'm not sure where/how to split the different ERB template documentations. Are there two implementations in the standard library (erb, erbrb)?

@jeremyevans
Copy link
Owner

Thank you very much for working on this. For erb, have the general documentation in the erubi.rb template file as it is the default, with only erb-engine specific information in the erb.rb file.

@muellerj
Copy link
Author

I'm done with the initial move - could you please check the assignment for the ERB and Markdown templates in particular?

@muellerj
Copy link
Author

@jeremyevans If you have changes that need to go into this PR, please feel free to commit to this branch

@jeremyevans
Copy link
Owner

This looks great, thank you! A few minor things I noticed:

@muellerj
Copy link
Author

Thanks for your guidance, a pleasure to help. I have integrated these changes - one question about the related modules remains in my mind:

For classes, which are defined in the following manner, the RDoc refernences work fine:

module Tilt
  class ERBTemplate < Template
    # ...
  end
end

For classes, which assign a constant via Tilt::StaticTemplate.subclass or directly from a Template, RDoc fails to generate proper links.

Tilt::SlimTemplate = Slim::Template

See rdoc/files/lib/tilt/commonmarker_rb.html for example.

How would you like me to proceed with these?

@jeremyevans
Copy link
Owner

Thanks for your guidance, a pleasure to help. I have integrated these changes - one question about the related modules remains in my mind:

For classes, which are defined in the following manner, the RDoc refernences work fine:

module Tilt
  class ERBTemplate < Template
    # ...
  end
end

For classes, which assign a constant via Tilt::StaticTemplate.subclass or directly from a Template, RDoc fails to generate proper links.

Tilt::SlimTemplate = Slim::Template

See rdoc/files/lib/tilt/commonmarker_rb.html for example.

How would you like me to proceed with these?

I think we should not include the Related module in this case. It's fine to do so as there are no documentable methods.

Thank you again for working on this. After the removal of the Related module for those templates, this looks good to merge. Then I'll setup a website to host the documentation.

@muellerj muellerj force-pushed the docs-refactoring branch 2 times, most recently from 79ab02f to 896bbde Compare September 26, 2025 16:41
@muellerj
Copy link
Author

Looks good to me, go ahead at your discretion!

Jonas Mueller added 2 commits September 26, 2025 18:43
The main template table in README.md links to these via rdoc-ref.

Remove TEMPLATES.md and convert docs from markdown to rdoc syntax.
@jeremyevans
Copy link
Owner

Merged at e109816. Will work on the website tomorrow. Thank you again for your patience and work in getting these changes prepared.

@jeremyevans
Copy link
Owner

Website now up: https://tilt.jeremyevans.net/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants