Thanks to visit codestin.com
Credit goes to github.com

Skip to content

4k view default and some fixes. #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

4k view default and some fixes. #300

merged 1 commit into from
Jan 11, 2023

Conversation

@jeremyje
Copy link
Owner

No description provided.

github-actions[bot]
github-actions bot reviewed Jan 10, 2023
View reviewed changes
docker-image/alpine/Dockerfile
RUN make SHORT_SHA=${VCS_REF} clean-build
RUN make SHORT_SHA=${VCS_REF} build
RUN make SHORT_SHA=${VCS_REF} test
RUN make SHORT_SHA=${VCS_REF} lint
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3059> reported by reviewdog 🐶
Multiple consecutive RUN instructions. Consider consolidation.

docker-image/alpine/Dockerfile
RUN make SHORT_SHA=${VCS_REF} build
RUN make SHORT_SHA=${VCS_REF} test
RUN make SHORT_SHA=${VCS_REF} lint
RUN make SHORT_SHA=${VCS_REF} build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3059> reported by reviewdog 🐶
Multiple consecutive RUN instructions. Consider consolidation.

docker-image/debian/Dockerfile
RUN make SHORT_SHA=${VCS_REF} clean-build
RUN make SHORT_SHA=${VCS_REF} build
RUN make SHORT_SHA=${VCS_REF} test
RUN make SHORT_SHA=${VCS_REF} lint
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3059> reported by reviewdog 🐶
Multiple consecutive RUN instructions. Consider consolidation.

docker-image/debian/Dockerfile
RUN make SHORT_SHA=${VCS_REF} build
RUN make SHORT_SHA=${VCS_REF} test
RUN make SHORT_SHA=${VCS_REF} lint
RUN make SHORT_SHA=${VCS_REF} build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [hadolint] <DL3059> reported by reviewdog 🐶
Multiple consecutive RUN instructions. Consider consolidation.

@jeremyje jeremyje merged commit df10bb3 into main Jan 11, 2023
@jeremyje jeremyje deleted the working branch January 11, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jeremyje