Guard doxygen CMake target in option, and namespace it. #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b594cc8 to
8554c59
Compare
Adds namespacing to doc and test targets. Adds the test-executables to default build target, to enable standard cmake workflow. Adjusts CI, no need to specify target here anymore. Removed MAKE_UNIT_TARGET_PROPERTIES.
8554c59 to
f9e27aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent collision with targets of other CMake-projects, like if someone fetch-contents both eve and kumi, as I think eve exposes a similar target (https://github.com/jfalcou/eve/blob/main/cmake/config/doxygen.cmake#L12).
Off by default so
cmake && cmake --build && ctest && cmake --installdoes not do anything unecessary.Added tests to default target and removed explicit targets from CI. Also removed
MAKE_UNIT_TARGET_PROPERTIES, since it seemed unnused, and now one would have to check if it exists, since other parameters ofset_target_propertieswas removed.