Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add @SuppressWarnings("FallThrough") on generated lexer. #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 17, 2018
Merged

Add @SuppressWarnings("FallThrough") on generated lexer. #454

merged 4 commits into from
Oct 17, 2018

Conversation

@regisd
Copy link
Member

@regisd regisd commented Oct 16, 2018 •
edited
Loading

Work around error-prone fall-through violations in geneated code (#222) for people using javac -Xep:FallThrough:ERROR

@regisd regisd requested a review from lsf37 as a code owner October 16, 2018 08:54
@regisd regisd self-assigned this Oct 16, 2018
@regisd regisd added the bug Not working as intended label Oct 16, 2018
@regisd regisd added this to the 1.7.1 milestone Oct 16, 2018
@regisd regisd force-pushed the suppresswarnings-error-prone branch from d6e1aea to 4d26c6b Compare October 16, 2018 09:02
lsf37
lsf37 approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisd regisd merged commit 22689eb into jflex-de:master Oct 17, 2018
@regisd regisd deleted the suppresswarnings-error-prone branch October 17, 2018 10:22
regisd pushed a commit that referenced this pull request Oct 17, 2018
@traviscibot
Pseudo-Merge commit 22689eb
ba37fe8 
Author: Régis Décamps <[email protected]>
Date:   Wed Oct 17 12:22:25 2018 +0200

     Add @SuppressWarnings("FallThrough") on generated lexer. (#454)

    * Enabled Error-prone FallThrough WARN in Bazel

    * Add @SuppressWarnings("FallThrough") on generated lexer.

    * Let Travis use the project's bazelrc

Updated from target/jflex-parent-1.7.1-SNAPSHOT-sources.jar
@regisd regisd mentioned this pull request Oct 18, 2018
Closed
@lsf37 lsf37 modified the milestones: 1.7.1, 1.8.0 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsf37 lsf37 lsf37 approved these changes

Assignees

@regisd regisd

Labels

bug Not working as intended

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@regisd @lsf37