Use Truth for all test assertions #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Structural replace; I didn't look at the details.
Structural replace; I didn't look at the details.
regisd
added a commit
to regisd/jflex
that referenced
this pull request
Dec 12, 2019
Follow-up of jflex-de#660 that reveals some jUnit assertions where inverting expected and actual.
regisd
added a commit
that referenced
this pull request
Dec 14, 2019
* Increase many error-prone checks from WARN to ERROR * Exclude third_party and generated code from checks * Fix error-prone TruthConstantAsserts Follow-up of #660 that reveals some jUnit assertions where inverting expected and actual. * Fix error-prone AssertionFailureIgnored * Fix error-prone ThrowsUncheckedException in initthrow_eol * Fix error-prone ThrowsUncheckedException * Fix error-prone ThrowsUncheckedException Make MacroException a checked exception * Fix error-prone ThrowsUncheckedException * Fix error-prone ClassCanBeStatic * Fix error-prone BoxedPrimitiveConstructor The problem was with new Integer(). Replaced by Integer.valueOf(). * Show error-prone warnings for CatchAndPrintStackTrace, DefaultCharSet, DeprecatedThreadMethods, IncrementInForLoopAndHeader, JdkObsolete, MissingOverride, FieldCanBeFinal, RemoveUnusedImports * expandMacro can throw a MacroException * Declare that IntCharSet implements Comparable<IntCharSet> The compare() method already exists. * Extract IntCharSetComparator
regisd
pushed a commit
that referenced
this pull request
Dec 14, 2019
commit b34361f Author: Régis Décamps <[email protected]> AuthorDate: Sat Dec 14 12:08:16 2019 +0100 Commit: GitHub <[email protected]> CommitDate: Sat Dec 14 12:08:16 2019 +0100 Fix error-prone violations (#683) * Increase many error-prone checks from WARN to ERROR * Exclude third_party and generated code from checks * Fix error-prone TruthConstantAsserts Follow-up of #660 that reveals some jUnit assertions where inverting expected and actual. * Fix error-prone AssertionFailureIgnored * Fix error-prone ThrowsUncheckedException in initthrow_eol * Fix error-prone ThrowsUncheckedException * Fix error-prone ThrowsUncheckedException Make MacroException a checked exception * Fix error-prone ThrowsUncheckedException * Fix error-prone ClassCanBeStatic * Fix error-prone BoxedPrimitiveConstructor The problem was with new Integer(). Replaced by Integer.valueOf(). * Show error-prone warnings for CatchAndPrintStackTrace, DefaultCharSet, DeprecatedThreadMethods, IncrementInForLoopAndHeader, JdkObsolete, MissingOverride, FieldCanBeFinal, RemoveUnusedImports * expandMacro can throw a MacroException * Declare that IntCharSet implements Comparable<IntCharSet> The compare() method already exists. * Extract IntCharSetComparator Updated from target/jflex-parent-1.8.0-SNAPSHOT-sources.jar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use https://github.com/google/truth on all test assertions.