Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix unarchive for read-only folders #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jan 4, 2024
Merged

Fix unarchive for read-only folders #1

merged 26 commits into from
Jan 4, 2024

Conversation

@omerzi
Copy link
Member

@omerzi omerzi commented Dec 24, 2023

No description provided.

@omerzi omerzi requested a review from yahavi December 24, 2023 11:42
@omerzi omerzi added the improvement Automatically generated release notes label Dec 24, 2023
yahavi
yahavi requested changes Jan 4, 2024
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🥇
Let's add a test that does unarchive for a zip containing a directory without write permissions.

@omerzi omerzi merged commit 8851a10 into jfrog:v3 Jan 4, 2024
@omerzi omerzi changed the title Fix unarchive readonly folders Fix unarchive for read-only folders Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yahavi yahavi yahavi requested changes

Assignees

No one assigned

Labels

improvement Automatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@omerzi @yahavi